Bladeren bron

removed stranded `if (icon)` statement

telamonian 5 jaren geleden
bovenliggende
commit
0170ca8e8f
1 gewijzigde bestanden met toevoegingen van 18 en 19 verwijderingen
  1. 18 19
      packages/settingeditor/src/pluginlist.tsx

+ 18 - 19
packages/settingeditor/src/pluginlist.tsx

@@ -269,25 +269,24 @@ namespace Private {
       const iconClass = getHint(ICON_CLASS_KEY, registry, plugin);
       const iconTitle = getHint(ICON_LABEL_KEY, registry, plugin);
 
-      if (icon)
-        return (
-          <li
-            className={id === selection ? 'jp-mod-selected' : ''}
-            data-id={id}
-            key={id}
-            title={itemTitle}
-          >
-            <LabIcon.resolveReact
-              icon={icon}
-              iconClass={iconClass}
-              fallback={settingsIcon}
-              title={iconTitle}
-              tag="span"
-              kind="settingsEditor"
-            />
-            <span>{schema.title || id}</span>
-          </li>
-        );
+      return (
+        <li
+          className={id === selection ? 'jp-mod-selected' : ''}
+          data-id={id}
+          key={id}
+          title={itemTitle}
+        >
+          <LabIcon.resolveReact
+            icon={icon}
+            iconClass={iconClass}
+            fallback={settingsIcon}
+            title={iconTitle}
+            tag="span"
+            kind="settingsEditor"
+          />
+          <span>{schema.title || id}</span>
+        </li>
+      );
     });
 
     ReactDOM.unmountComponentAtNode(node);