Bladeren bron

Remove a menu from the main menu when it is disposed

Steven Silvester 8 jaren geleden
bovenliggende
commit
063d0615d5
1 gewijzigde bestanden met toevoegingen van 5 en 2 verwijderingen
  1. 5 2
      src/mainmenu/index.ts

+ 5 - 2
src/mainmenu/index.ts

@@ -72,8 +72,11 @@ class MainMenu extends MenuBar implements IMainMenu {
     let rankItem = { menu, rank };
     let index = upperBound(this._items, rankItem, Private.itemCmp);
 
-    // Upon disposal, remove the menu reference from the rank list.
-    menu.disposed.connect(() => this._items.remove(rankItem));
+    // Upon disposal, remove the menu and its rank reference.
+    menu.disposed.connect(() => {
+      this.removeMenu(menu);
+      this._items.remove(rankItem);
+    });
 
     this._items.insert(index, rankItem);
     this.insertMenu(index, menu);