浏览代码

Add labels to the dialog inputs

Steven Silvester 8 年之前
父节点
当前提交
16abc56566
共有 3 个文件被更改,包括 39 次插入2 次删除
  1. 9 0
      src/dialog/index.css
  2. 1 1
      src/docregistry/kernelselector.ts
  3. 29 1
      src/filebrowser/dialogs.ts

+ 9 - 0
src/dialog/index.css

@@ -60,6 +60,8 @@
 
 
 .jp-Dialog-bodyContent {
+  display: flex;
+  flex-direction: column;
   font-size: 15px;
   overflow: auto;
 }
@@ -110,6 +112,13 @@
   color: white;
 }
 
+
+.jp-Dialog-bodyContent > label {
+  padding-top: 4px;
+  padding-bottom: 4px
+}
+
+
 .jp-Dialog-inputWrapper {
   display: flex;
   background: white;

+ 1 - 1
src/docregistry/kernelselector.ts

@@ -96,7 +96,7 @@ function selectKernel(options: IKernelSelection): Promise<Kernel.IModel> {
 
   // Create the dialog body.
   let body = document.createElement('div');
-  let text = document.createElement('pre');
+  let text = document.createElement('label');
   text.textContent = `Select kernel for\n"${options.name}"`;
   body.appendChild(text);
   if (kernel) {

+ 29 - 1
src/filebrowser/dialogs.ts

@@ -332,6 +332,7 @@ class CreateFromHandler extends Widget {
         { specs, sessions, preferredKernel, preference }
       );
     } else {
+      this.node.removeChild(this.kernelDropdownNode.previousSibling);
       this.node.removeChild(this.kernelDropdownNode);
     }
 
@@ -581,11 +582,20 @@ namespace Private {
   export
   function createOpenWithNode(): HTMLElement {
     let body = document.createElement('div');
-    let name = document.createElement('span');
+    let nameTitle = document.createElement('label');
+    nameTitle.textContent = 'File Name';
+    let name = document.createElement('div');
+    let widgetTitle = document.createElement('label');
+    widgetTitle.textContent = 'Widget Type';
     let widgetDropdown = document.createElement('select');
+    let kernelTitle = document.createElement('label');
+    kernelTitle.textContent = 'Kernel';
     let kernelDropdownNode = document.createElement('select');
+    body.appendChild(nameTitle);
     body.appendChild(name);
+    body.appendChild(widgetTitle);
     body.appendChild(widgetDropdown);
+    body.appendChild(kernelTitle);
     body.appendChild(kernelDropdownNode);
     return body;
   }
@@ -596,13 +606,25 @@ namespace Private {
   export
   function createCreateNewNode(): HTMLElement {
     let body = document.createElement('div');
+    let nameTitle = document.createElement('label');
+    nameTitle.textContent = 'File Name';
     let name = document.createElement('input');
+    let typeTitle = document.createElement('label');
+    typeTitle.textContent = 'File Type';
     let fileTypeDropdown = document.createElement('select');
+    let widgetTitle = document.createElement('label');
+    widgetTitle.textContent = 'Widget Type';
     let widgetDropdown = document.createElement('select');
+    let kernelTitle = document.createElement('label');
+    kernelTitle.textContent = 'Kernel';
     let kernelDropdownNode = document.createElement('select');
+    body.appendChild(nameTitle);
     body.appendChild(name);
+    body.appendChild(typeTitle);
     body.appendChild(fileTypeDropdown);
+    body.appendChild(widgetTitle);
     body.appendChild(widgetDropdown);
+    body.appendChild(kernelTitle);
     body.appendChild(kernelDropdownNode);
     return body;
   }
@@ -613,9 +635,15 @@ namespace Private {
   export
   function createCreateFromNode(): HTMLElement {
     let body = document.createElement('div');
+    let nameTitle = document.createElement('label');
+    nameTitle.textContent = 'File Name';
     let name = document.createElement('input');
+    let kernelTitle = document.createElement('label');
+    kernelTitle.textContent = 'Kernel';
     let kernelDropdownNode = document.createElement('select');
+    body.appendChild(nameTitle);
     body.appendChild(name);
+    body.appendChild(kernelTitle);
     body.appendChild(kernelDropdownNode);
     return body;
   }