Browse Source

Remove unreliable test that was not testing what it was purported to.

Ian Rose 6 years ago
parent
commit
219137af0b
2 changed files with 1 additions and 35 deletions
  1. 0 34
      tests/test-cells/src/widget.spec.ts
  2. 1 1
      tests/test-notebook/src/actions.spec.ts

+ 0 - 34
tests/test-cells/src/widget.spec.ts

@@ -502,40 +502,6 @@ describe('cells/widget', () => {
         expect(widget.node.classList.contains(RENDERED_CLASS)).to.equal(false);
         widget.dispose();
       });
-
-      it('should ignore being set to the same value', async () => {
-        const widget = new LogMarkdownCell({
-          model,
-          rendermime,
-          contentFactory
-        });
-        widget.rendered = false;
-        Widget.attach(widget, document.body);
-
-        // Count how many update requests were processed.
-        await framePromise();
-        const original = widget.methods.filter(method => {
-          return method === 'onUpdateRequest';
-        }).length;
-
-        widget.rendered = false;
-        widget.rendered = false;
-        widget.rendered = false;
-        widget.rendered = false;
-
-        // Count how many update requests were processed
-        await framePromise();
-        const delta =
-          widget.methods.filter(method => {
-            return method === 'onUpdateRequest';
-          }).length - original;
-
-        // Make sure every single `rendered` toggle did not trigger an update.
-        expect(delta)
-          .to.be.gte(0)
-          .and.lte(1);
-        widget.dispose();
-      });
     });
 
     describe('#dispose()', () => {

+ 1 - 1
tests/test-notebook/src/actions.spec.ts

@@ -566,7 +566,7 @@ describe('@jupyterlab/notebook', () => {
         expect(result).to.equal(true);
         expect(cell.model.outputs.length).to.be.above(0);
         expect(next.rendered).to.equal(true);
-      });
+      }).timeout(30000); // Allow for slower CI
 
       it('should be a no-op if there is no model', async () => {
         widget.model = null;