Browse Source

Do not attempt to select directories in goToPath

Trevor Slaton 5 years ago
parent
commit
25f2d830e9
1 changed files with 10 additions and 9 deletions
  1. 10 9
      packages/filebrowser-extension/src/index.ts

+ 10 - 9
packages/filebrowser-extension/src/index.ts

@@ -452,18 +452,19 @@ function addCommands(
     execute: async args => {
       const path = (args.path as string) || '';
       try {
-        await Private.navigateToPath(path, factory);
+        const item = await Private.navigateToPath(path, factory);
+        if (item.type !== 'directory') {
+          const browserForPath = Private.getBrowserForPath(path, factory);
+          browserForPath.clearSelectedItems();
+          const parts = path.split('/');
+          const name = parts[parts.length - 1];
+          if (name) {
+            await browserForPath.selectItemByName(name);
+          }
+        }
       } catch (reason) {
         console.warn(`${CommandIDs.goToPath} failed to go to: ${path}`, reason);
       }
-      const browserForPath = Private.getBrowserForPath(path, factory);
-      browserForPath.clearSelectedItems();
-      const parts = path.split('/');
-      const name = parts[parts.length - 1];
-      if (name) {
-        await browserForPath.selectItemByName(name);
-      }
-
       return commands.execute(CommandIDs.showBrowser, { path });
     }
   });