Parcourir la source

rendermime: Don't stop if error in canRender

In rendermime, if an error occured when the canRender() function is
called, the notebook should not stop and break. Rather it should
continue and attempt others.
AbdealiJK il y a 8 ans
Parent
commit
2805abdf02
1 fichiers modifiés avec 8 ajouts et 1 suppressions
  1. 8 1
      src/rendermime/rendermime.ts

+ 8 - 1
src/rendermime/rendermime.ts

@@ -146,7 +146,14 @@ class RenderMime {
       if (model.data.has(mimeType)) {
         let options = { mimeType, model, sanitizer };
         let renderer = this._renderers[mimeType];
-        if (renderer.canRender(options)) {
+        let canRender = false;
+        try {
+          canRender = renderer.canRender(options);
+        } catch (err) {
+          console.error(
+            `Got an error when checking the renderer for the mimeType '${mimeType}'\n`, err);
+        }
+        if (canRender) {
           return true;
         }
       }