Browse Source

try pinning node, more recent puppeteer

Nicholas Bollweg 4 years ago
parent
commit
2eeffc86d9
2 changed files with 3 additions and 3 deletions
  1. 2 2
      jupyterlab/browser_check.py
  2. 1 1
      scripts/release_test.sh

+ 2 - 2
jupyterlab/browser_check.py

@@ -154,7 +154,7 @@ async def run_browser(url):
         if not osp.exists(target):
             os.makedirs(osp.join(target))
         await run_async_process(["jlpm", "init", "-y"], cwd=target)
-        await run_async_process(["jlpm", "add", "puppeteer@^4"], cwd=target)
+        await run_async_process(["jlpm", "add", "puppeteer@^7"], cwd=target)
     shutil.copy(osp.join(here, 'chrome-test.js'), osp.join(target, 'chrome-test.js'))
     await run_async_process(["node", "chrome-test.js", url], cwd=target)
 
@@ -166,7 +166,7 @@ def run_browser_sync(url):
     if not osp.exists(osp.join(target, 'node_modules')):
         os.makedirs(target)
         subprocess.call(["jlpm", "init", "-y"], cwd=target)
-        subprocess.call(["jlpm", "add", "puppeteer@^2"], cwd=target)
+        subprocess.call(["jlpm", "add", "puppeteer@^7"], cwd=target)
     shutil.copy(osp.join(here, 'chrome-test.js'), osp.join(target, 'chrome-test.js'))
     return subprocess.check_call(["node", "chrome-test.js", url], cwd=target)
 

+ 1 - 1
scripts/release_test.sh

@@ -10,7 +10,7 @@ set -ex
 JLAB_TEST_ENV="${CONDA_DEFAULT_ENV}_test"
 TEST_DIR=$(mktemp -d -t ${JLAB_TEST_ENV}XXXXX)
 
-conda create --override-channels --strict-channel-priority -c conda-forge -c nodefaults -y -n "$JLAB_TEST_ENV" nodejs pip wheel setuptools
+conda create --override-channels --strict-channel-priority -c conda-forge -c nodefaults -y -n "$JLAB_TEST_ENV" 'nodejs>=10,!=13,<15' pip wheel setuptools
 conda activate "$JLAB_TEST_ENV"
 
 python -m pip install $(ls dist/*.whl)