Browse Source

Merge pull request #3590 from blink1073/fix-dev-mode-stripe

Fix handling of dev mode
Ian Rose 7 năm trước cách đây
mục cha
commit
31e8e5ae9a
2 tập tin đã thay đổi với 4 bổ sung3 xóa
  1. 3 2
      CONTRIBUTING.md
  2. 1 1
      packages/application/src/index.ts

+ 3 - 2
CONTRIBUTING.md

@@ -114,8 +114,9 @@ jupyter lab --dev-mode
 ```
 
 Development mode ensures that you are running the JavaScript assets that are
-built in the dev-installed Python package.  When running from source in development
-mode, the page will have a red stripe at the top to indicate it is an unreleased version.
+built in the dev-installed Python package.  When running in dev mode, a red
+stripe will appear at the top of the page; this is to indicate running
+an unreleased version.
 
 ### Build and run the tests
 

+ 1 - 1
packages/application/src/index.ts

@@ -63,7 +63,7 @@ class JupyterLab extends Application<ApplicationShell> {
   constructor(options: JupyterLab.IOptions = {}) {
     super({ shell: new ApplicationShell() });
     this._info = { ...JupyterLab.defaultInfo, ...options };
-    if (options.devMode) {
+    if (this._info.devMode) {
       this.shell.addClass('jp-mod-devMode');
     }