Jason Grout 4 years ago
parent
commit
3ab73dea2e
3 changed files with 9 additions and 7 deletions
  1. 1 1
      builder/metadata_schema.json
  2. 8 3
      builder/src/webpack.config.ext.ts
  3. 0 3
      tsconfigdoc.json

+ 1 - 1
builder/metadata_schema.json

@@ -93,7 +93,7 @@
     },
     "sharedPackages": {
       "description": "Modules that should be shared in the share scope. When provided, property names are used to match requested modules in this compilation.",
-        "ref": "#/definitions/sharedObject"
+      "ref": "#/definitions/sharedObject"
     },
     "discovery": {
       "title": "Discovery metadata",

+ 8 - 3
builder/src/webpack.config.ext.ts

@@ -101,7 +101,7 @@ const sharedPackages = data.jupyterlab.sharedPackages ?? {};
 Object.keys(sharedPackages).forEach(pkg => {
   if (sharedPackages[pkg] === false) {
     delete shared[pkg];
-    delete sharedPackages[pkg];  
+    delete sharedPackages[pkg];
   }
 });
 
@@ -110,7 +110,10 @@ Object.keys(sharedPackages).forEach(pkg => {
   // Convert `bundled` to `import`
   if (sharedPackages[pkg].bundled === false) {
     sharedPackages[pkg].import = false;
-  } else if (sharedPackages[pkg].bundled === true && shared[pkg]?.import === false) {
+  } else if (
+    sharedPackages[pkg].bundled === true &&
+    shared[pkg]?.import === false
+  ) {
     // We can't delete a key in the merge, so we have to delete it in the source
     delete shared[pkg].import;
   }
@@ -121,7 +124,9 @@ shared = merge(shared, sharedPackages);
 
 // add the root module itself to shared
 if (shared[data.name]) {
-  console.error(`The root package itself '${data.name}' may not specified as a shared dependency.`);
+  console.error(
+    `The root package itself '${data.name}' may not specified as a shared dependency.`
+  );
 }
 shared[data.name] = {
   version: data.version,

+ 0 - 3
tsconfigdoc.json

@@ -230,9 +230,6 @@
     {
       "path": "./packages/statusbar-extension"
     },
-    {
-      "path": "./packages/tabmanager-extension"
-    },
     {
       "path": "./packages/terminal"
     },