Browse Source

Fix disabling of extensions

Steven Silvester 7 years ago
parent
commit
47b98de4de
2 changed files with 2 additions and 3 deletions
  1. 1 3
      jupyterlab/commands.py
  2. 1 0
      jupyterlab/tests/test_jupyterlab.py

+ 1 - 3
jupyterlab/commands.py

@@ -839,8 +839,7 @@ def _toggle_extension(extension, value, app_dir=None, logger=None):
     """Enable or disable a lab extension.
     """
     app_dir = get_app_dir(app_dir)
-    extensions = _get_extensions(app_dir)
-    config = _get_build_config(app_dir)
+    config = _get_page_config(app_dir)
     disabled = config.get('disabledExtensions', [])
     if value and extension not in disabled:
         disabled.append(extension)
@@ -850,7 +849,6 @@ def _toggle_extension(extension, value, app_dir=None, logger=None):
     _write_page_config(config, app_dir, logger=logger)
 
 
-
 def _write_build_config(config, app_dir, logger):
     """Write the build config to the app dir.
     """

+ 1 - 0
jupyterlab/tests/test_jupyterlab.py

@@ -326,6 +326,7 @@ class TestExtension(TestCase):
         disable_extension('@jupyterlab/notebook-extension', app_dir)
         disabled = _get_disabled(app_dir)
         assert '@jupyterlab/notebook-extension' in disabled
+        assert '@jupyterlab/python-tests' in disabled
 
     def test_enable_extension(self):
         app_dir = self.tempdir()