Parcourir la source

Merge pull request #5396 from blink1073/fix-browser-test

Fix browser test
Steven Silvester il y a 6 ans
Parent
commit
4845c45a38
3 fichiers modifiés avec 13 ajouts et 12 suppressions
  1. 3 2
      buildutils/src/ensure-package.ts
  2. 5 5
      dev_mode/index.js
  3. 5 5
      jupyterlab/staging/index.js

+ 3 - 2
buildutils/src/ensure-package.ts

@@ -133,8 +133,9 @@ export async function ensurePackage(
     if (!fs.existsSync(target)) {
       return;
     }
-    references[name] = path.relative(path.join(pkgPath, 'src'), locals[name]);
-    references[name] = path.join(references[name], 'src');
+    let ref = path.relative(path.join(pkgPath, 'src'), locals[name]);
+    ref = path.join(ref, 'src');
+    references[name] = ref.split(path.sep).join('/');
   });
   if (
     data.name.indexOf('test-') === -1 &&

+ 5 - 5
dev_mode/index.js

@@ -162,12 +162,12 @@ function main() {
 
   // Handle a browser test.
   var browserTest = PageConfig.getOption('browserTest');
-  var el = document.createElement('div');
-  el.id = 'browserTest';
-  document.body.appendChild(el);
-  el.textContent = '[]';
-
   if (browserTest.toLowerCase() === 'true') {
+    var el = document.createElement('div');
+    el.id = 'browserTest';
+    document.body.appendChild(el);
+    el.textContent = '[]';
+    el.style.display = 'none';
     var errors = [];
     var reported = false;
     var timeout = 25000;

+ 5 - 5
jupyterlab/staging/index.js

@@ -162,12 +162,12 @@ function main() {
 
   // Handle a browser test.
   var browserTest = PageConfig.getOption('browserTest');
-  var el = document.createElement('div');
-  el.id = 'browserTest';
-  document.body.appendChild(el);
-  el.textContent = '[]';
-
   if (browserTest.toLowerCase() === 'true') {
+    var el = document.createElement('div');
+    el.id = 'browserTest';
+    document.body.appendChild(el);
+    el.textContent = '[]';
+    el.style.display = 'none';
     var errors = [];
     var reported = false;
     var timeout = 25000;