Browse Source

Merge pull request #6676 from ian-r-rose/default-screen-reader-terminal-to-false

Default screen reader mode on terminals to false
Jason Grout 5 years ago
parent
commit
4c61ea3796
2 changed files with 9 additions and 5 deletions
  1. 8 2
      packages/terminal-extension/schema/plugin.json
  2. 1 3
      packages/terminal/src/tokens.ts

+ 8 - 2
packages/terminal-extension/schema/plugin.json

@@ -51,6 +51,12 @@
       "$ref": "#/definitions/theme",
       "default": "inherit"
     },
+    "screenReaderMode": {
+      "title": "Screen Reader Mode",
+      "description": "Add accessibility elements for use with screen readers.",
+      "type": "boolean",
+      "default": false
+    },
     "scrollback": {
       "title": "Scrollback Buffer",
       "description": "The amount of scrollback beyond initial viewport",
@@ -59,13 +65,13 @@
     },
     "shutdownOnClose": {
       "title": "Shut down on close",
-      "description": "Whether to shut down or not the session when closing the terminal.",
+      "description": "Shut down the session when closing the terminal.",
       "type": "boolean",
       "default": false
     },
     "pasteWithCtrlV": {
       "title": "Paste with Ctrl+V",
-      "description": "Whether to enable pasting with Ctrl+V.  This can be disabled to use Ctrl+V in the vi editor, for instance.  This setting has no effect on macOS, where Cmd+V is available",
+      "description": "Enable pasting with Ctrl+V.  This can be disabled to use Ctrl+V in the vi editor, for instance.  This setting has no effect on macOS, where Cmd+V is available",
       "type": "boolean",
       "default": true
     }

+ 1 - 3
packages/terminal/src/tokens.ts

@@ -97,8 +97,6 @@ export namespace ITerminal {
 
     /**
      * Whether to enable screen reader support.
-     *
-     * Set to false if you run into performance problems from DOM overhead
      */
     screenReaderMode: boolean;
 
@@ -122,7 +120,7 @@ export namespace ITerminal {
     shutdownOnClose: false,
     cursorBlink: true,
     initialCommand: '',
-    screenReaderMode: true,
+    screenReaderMode: false, // False by default, can cause scrollbar mouse interaction issues.
     pasteWithCtrlV: true
   };