浏览代码

Avoid shadowing builtin

Vidar Tonaas Fauske 7 年之前
父节点
当前提交
4f3753aeee
共有 3 个文件被更改,包括 4 次插入4 次删除
  1. 2 2
      jupyterlab/commands.py
  2. 1 1
      jupyterlab/labextensions.py
  3. 1 1
      jupyterlab/tests/test_jupyterlab.py

+ 2 - 2
jupyterlab/commands.py

@@ -235,12 +235,12 @@ def uninstall_extension(name, app_dir=None, logger=None):
     return handler.uninstall_extension(name)
 
 
-def update_extension(name=None, all=False, app_dir=None, logger=None):
+def update_extension(name=None, all_=False, app_dir=None, logger=None):
     """Update an extension by name.
     """
     _node_check()
     handler = _AppHandler(app_dir, logger)
-    return handler.update_extension(name, all)
+    return handler.update_extension(name, all_)
 
 
 def clean(app_dir=None):

+ 1 - 1
jupyterlab/labextensions.py

@@ -121,7 +121,7 @@ class UpdateLabExtensionApp(BaseExtensionApp):
             self.log.warn('Specify an extension to update, or use --all to update all extensions')
             return False
         if self.all:
-            return update_extension(all=True, app_dir=self.app_dir, logger=self.log)
+            return update_extension(all_=True, app_dir=self.app_dir, logger=self.log)
         return any([
             update_extension(name=arg, app_dir=self.app_dir, logger=self.log)
             for arg in self.extra_args

+ 1 - 1
jupyterlab/tests/test_jupyterlab.py

@@ -617,5 +617,5 @@ class TestExtension(TestCase):
         )
 
         with p1, p2:
-            assert True == update_extension(None, all=True)
+            assert True == update_extension(None, all_=True)
         assert sorted(updated) == [self.pkg_names['extension'], self.pkg_names['mimeextension']]