소스 검색

fixed readmes, final code cleaning

markellekelly 5 년 전
부모
커밋
5067aed922
5개의 변경된 파일11개의 추가작업 그리고 19개의 파일을 삭제
  1. 3 2
      packages/celltags-extension/README.md
  2. 3 2
      packages/celltags/README.md
  3. 0 4
      packages/celltags/src/addwidget.ts
  4. 1 1
      packages/celltags/src/tool.ts
  5. 4 10
      packages/celltags/src/widget.ts

+ 3 - 2
packages/celltags-extension/README.md

@@ -1,3 +1,4 @@
-# celltags
+# @jupyterlab/celltags-extension
 
-A refactor of jupyterlab-celltags intended to be merged into core.
+A JupyterLab extension which provides an entry point for
+[@jupyterlab/celltags](../celltags).

+ 3 - 2
packages/celltags/README.md

@@ -1,3 +1,4 @@
-# celltags
+# @jupyterlab/celltags
 
-A refactor of jupyterlab-celltags intended to be merged into core.
+A JupyterLab package which provides an interface for viewing and manipulating
+descriptive tags in notebook cell metadata.

+ 0 - 4
packages/celltags/src/addwidget.ts

@@ -118,8 +118,6 @@ export class AddWidget extends Widget {
 
   /**
    * Handle the `'focus'` event for the input box.
-   *
-   * @param event - The DOM event sent to the widget
    */
   private _evtFocus() {
     if (!this.editing) {
@@ -151,8 +149,6 @@ export class AddWidget extends Widget {
 
   /**
    * Handle the `'focusout'` event for the input box.
-   *
-   * @param event - The DOM event sent to the widget
    */
   private _evtBlur() {
     if (this.editing) {

+ 1 - 1
packages/celltags/src/tool.ts

@@ -247,7 +247,7 @@ export class TagTool extends NotebookTools.Tool {
     this.validateTags(this.tracker.activeCell, taglist);
   }
 
+  public tracker: INotebookTracker = null;
   private tagList: string[] = [];
   private header: boolean = false;
-  public tracker: INotebookTracker = null;
 }

+ 4 - 10
packages/celltags/src/widget.ts

@@ -83,10 +83,10 @@ export class TagWidget extends Widget {
         this._evtClick();
         break;
       case 'mouseover':
-        this._evtMouseOver(event as MouseEvent);
+        this._evtMouseOver();
         break;
       case 'mouseout':
-        this._evtMouseOut(event as MouseEvent);
+        this._evtMouseOut();
         break;
       default:
         break;
@@ -123,8 +123,6 @@ export class TagWidget extends Widget {
 
   /**
    * Handle the `'click'` event for the widget.
-   *
-   * @param event - The DOM event sent to the widget
    */
   private _evtClick() {
     if (this.applied) {
@@ -137,19 +135,15 @@ export class TagWidget extends Widget {
 
   /**
    * Handle the `'mouseover'` event for the widget.
-   *
-   * @param event - The DOM event sent to the widget
    */
-  private _evtMouseOver(event: MouseEvent) {
+  private _evtMouseOver() {
     (this.node as HTMLElement).classList.add('tag-hover');
   }
 
   /**
    * Handle the `'mouseout'` event for the widget.
-   *
-   * @param event - The DOM event sent to the widget
    */
-  private _evtMouseOut(event: MouseEvent) {
+  private _evtMouseOut() {
     (this.node as HTMLElement).classList.remove('tag-hover');
   }