Browse Source

Merge pull request #2734 from blink1073/update-requirejs-example

Update the services requirejs example
Afshin Darian 7 years ago
parent
commit
625aef7f48

+ 1 - 1
packages/services/examples/browser-require/index.html

@@ -29,7 +29,7 @@
     require.config({
     require.config({
         paths: {
         paths: {
           'jquery': 'https://code.jquery.com/jquery-2.2.4.min',
           'jquery': 'https://code.jquery.com/jquery-2.2.4.min',
-          '@jupyterlab/services': 'https://unpkg.com/@jupyterlab/services@^0.34/dist/index',
+          '@jupyterlab/services': 'https://unpkg.com/@jupyterlab/services@^0.48/dist/index',
         }
         }
     });
     });
     </script>
     </script>

+ 2 - 2
packages/services/examples/browser-require/index.js

@@ -37,10 +37,10 @@ require(['jquery', '@jupyterlab/services'], function ($, services) {
         console.log('Got execute reply');
         console.log('Got execute reply');
       };
       };
 
 
-      future.onDone = function () {
+      future.done.then(function () {
         console.log('Future is fulfilled');
         console.log('Future is fulfilled');
         $('#output').append($('<pre>').text('Done!'));
         $('#output').append($('<pre>').text('Done!'));
-      };
+      });
     });
     });
   });
   });
 });
 });

+ 1 - 1
packages/services/examples/typescript-browser-with-output/package.json

@@ -17,7 +17,7 @@
     "style-loader": "^0.13.1",
     "style-loader": "^0.13.1",
     "tslint": "~4.5.0",
     "tslint": "~4.5.0",
     "typescript": "~2.4.1",
     "typescript": "~2.4.1",
-    "webpack": "~2.2.1"
+    "webpack": "^2.2.1"
   },
   },
   "version": "0.5.0"
   "version": "0.5.0"
 }
 }