瀏覽代碼

Fix comm target callback signature.

Jason Grout 7 年之前
父節點
當前提交
6b88d891fb
共有 2 個文件被更改,包括 2 次插入2 次删除
  1. 1 1
      packages/services/src/kernel/default.ts
  2. 1 1
      packages/services/src/kernel/kernel.ts

+ 1 - 1
packages/services/src/kernel/default.ts

@@ -623,7 +623,7 @@ class DefaultKernel implements Kernel.IKernel {
    * callback will be overidden.  A registered comm target handler will take
    * precedence over a comm which specifies a `target_module`.
    */
-  registerCommTarget(targetName: string, callback: (comm: Kernel.IComm, msg: KernelMessage.ICommOpenMsg) => void): IDisposable {
+  registerCommTarget(targetName: string, callback: (comm: Kernel.IComm, msg: KernelMessage.ICommOpenMsg) => Promise<void> | void): IDisposable {
     this._targetRegistry[targetName] = callback;
     return new DisposableDelegate(() => {
       if (!this.isDisposed) {

+ 1 - 1
packages/services/src/kernel/kernel.ts

@@ -323,7 +323,7 @@ namespace Kernel {
      * callback will be overidden.  A registered comm target handler will take
      * precedence over a comm which specifies a `target_module`.
      */
-    registerCommTarget(targetName: string, callback: (comm: Kernel.IComm, msg: KernelMessage.ICommOpenMsg) => Promise<void>): IDisposable;
+    registerCommTarget(targetName: string, callback: (comm: Kernel.IComm, msg: KernelMessage.ICommOpenMsg) => Promise<void> | void): IDisposable;
 
     /**
      * Register an IOPub message hook.