Browse Source

turned on strictNullChecks for logconsole pkg; added it to docs build

telamonian 4 years ago
parent
commit
6e04177593

+ 1 - 2
packages/logconsole-extension/tsconfig.json

@@ -2,8 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "outDir": "lib",
-    "rootDir": "src",
-    "strictNullChecks": false
+    "rootDir": "src"
   },
   "include": ["src/*"],
   "references": [

+ 3 - 6
packages/logconsole/src/widget.ts

@@ -88,10 +88,6 @@ class LogConsoleOutputPrompt extends Widget implements IOutputPrompt {
  * with prompts showing log timestamps.
  */
 class LogConsoleOutputArea extends OutputArea {
-  /**
-   * The rendermime instance used by the widget.
-   */
-  rendermime: IRenderMimeRegistry | null;
   /**
    * Output area model used by the widget.
    */
@@ -358,7 +354,8 @@ export class LogConsolePanel extends StackedPanel {
         const outputArea = this._outputAreas.get(viewId);
         if (outputArea) {
           if (change.newValue) {
-            outputArea.rendermime = change.newValue;
+            // cast away readonly
+            (outputArea.rendermime as IRenderMimeRegistry) = change.newValue;
           } else {
             outputArea.dispose();
           }
@@ -420,7 +417,7 @@ export class LogConsolePanel extends StackedPanel {
       // add view for logger if not exist
       if (!this._outputAreas.has(viewId)) {
         const outputArea = new LogConsoleOutputArea({
-          rendermime: logger.rendermime,
+          rendermime: logger.rendermime!,
           contentFactory: new LogConsoleContentFactory(),
           model: logger.outputAreaModel
         });

+ 1 - 2
packages/logconsole/tsconfig.json

@@ -2,8 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "outDir": "lib",
-    "rootDir": "src",
-    "strictNullChecks": false
+    "rootDir": "src"
   },
   "include": ["src/*"],
   "references": [

+ 0 - 3
packages/logconsole/tsconfig.test.json

@@ -1,8 +1,5 @@
 {
   "extends": "../../tsconfigbase.test",
-  "compilerOptions": {
-    "strictNullChecks": false
-  },
   "include": ["src/*", "test/*"],
   "references": [
     {

+ 0 - 1
packages/ui-components/.storybook/tsconfig.json

@@ -7,7 +7,6 @@
     "outDir": "dist",
     "noImplicitReturns": true,
     "noImplicitThis": true,
-    "strictNullChecks": true,
     "skipLibCheck": true
   },
   "include": ["../src/**/*"],

+ 2 - 5
typedoc.js

@@ -112,12 +112,9 @@ module.exports = {
     '**/tests/**',
     '**/testutils/**',
 
-    '**/packages/celltags/**',
-    '**/packages/logconsole/**'
+    '**/packages/celltags/**'
+    // '**/packages/logconsole/**'
     // '**/packages/settingregistry/**'
-
-    // '**/packages/celltags*/**',
-    // '**/packages/logconsole*/**',
   ],
   excludeNotExported: true,
   ignoreCompilerErrors: false,