Pārlūkot izejas kodu

Fix CSV viewer toolbar tests.

Jason Grout 7 gadi atpakaļ
vecāks
revīzija
7ecb3c83d4
1 mainītis faili ar 28 papildinājumiem un 28 dzēšanām
  1. 28 28
      tests/test-csvviewer/src/toolbar.spec.ts

+ 28 - 28
tests/test-csvviewer/src/toolbar.spec.ts

@@ -12,7 +12,7 @@ import {
 } from 'simulate-event';
 
 import {
-  CSVToolbar
+  CSVDelimiter
 } from '@jupyterlab/csvviewer';
 
 
@@ -21,22 +21,22 @@ const DELIMITERS = [',', ';', '\t'];
 
 describe('csvviewer/toolbar', () => {
 
-  describe('CSVToolbar', () => {
+  describe('CSVDelimiter', () => {
 
     describe('#constructor()', () => {
 
-      it('should instantiate a `CSVToolbar`', () => {
-        let toolbar = new CSVToolbar({ selected: ',' });
-        expect(toolbar).to.be.a(CSVToolbar);
-        expect(toolbar.node.classList).to.contain('jp-CSVToolbar');
-        toolbar.dispose();
+      it('should instantiate a `CSVDelimiter` toolbar widget', () => {
+        let widget = new CSVDelimiter({ selected: ',' });
+        expect(widget).to.be.a(CSVDelimiter);
+        expect(widget.node.classList).to.contain('jp-CSVDelimiter');
+        widget.dispose();
       });
 
       it('should allow pre-selecting the delimiter', () => {
         let wanted = DELIMITERS[DELIMITERS.length - 1];
-        let toolbar = new CSVToolbar({ selected: wanted });
-        expect(toolbar.selectNode.value).to.be(wanted);
-        toolbar.dispose();
+        let widget = new CSVDelimiter({ selected: wanted });
+        expect(widget.selectNode.value).to.be(wanted);
+        widget.dispose();
       });
 
     });
@@ -44,16 +44,16 @@ describe('csvviewer/toolbar', () => {
     describe('#delimiterChanged', () => {
 
       it('should emit a value when the dropdown value changes', () => {
-        let toolbar = new CSVToolbar({ selected: ',' });
+        let widget = new CSVDelimiter({ selected: ',' });
         let delimiter = '';
         let index = DELIMITERS.length - 1;
         let wanted = DELIMITERS[index];
-        toolbar.delimiterChanged.connect((s, value) => { delimiter = value; });
-        Widget.attach(toolbar, document.body);
-        toolbar.selectNode.selectedIndex = index;
-        simulate(toolbar.selectNode, 'change');
+        widget.delimiterChanged.connect((s, value) => { delimiter = value; });
+        Widget.attach(widget, document.body);
+        widget.selectNode.selectedIndex = index;
+        simulate(widget.selectNode, 'change');
         expect(delimiter).to.be(wanted);
-        toolbar.dispose();
+        widget.dispose();
       });
 
     });
@@ -61,9 +61,9 @@ describe('csvviewer/toolbar', () => {
     describe('#selectNode', () => {
 
       it('should return the delimiter dropdown select tag', () => {
-        let toolbar = new CSVToolbar({ selected: ',' });
-        expect(toolbar.selectNode.tagName.toLowerCase()).to.be('select');
-        toolbar.dispose();
+        let widget = new CSVDelimiter({ selected: ',' });
+        expect(widget.selectNode.tagName.toLowerCase()).to.be('select');
+        widget.dispose();
       });
 
     });
@@ -71,18 +71,18 @@ describe('csvviewer/toolbar', () => {
     describe('#dispose()', () => {
 
       it('should dispose of the resources held by the widget', () => {
-        let toolbar = new CSVToolbar({ selected: ',' });
-        expect(toolbar.isDisposed).to.be(false);
-        toolbar.dispose();
-        expect(toolbar.isDisposed).to.be(true);
+        let widget = new CSVDelimiter({ selected: ',' });
+        expect(widget.isDisposed).to.be(false);
+        widget.dispose();
+        expect(widget.isDisposed).to.be(true);
       });
 
       it('should be safe to call multiple times', () => {
-        let toolbar = new CSVToolbar({ selected: ',' });
-        expect(toolbar.isDisposed).to.be(false);
-        toolbar.dispose();
-        toolbar.dispose();
-        expect(toolbar.isDisposed).to.be(true);
+        let widget = new CSVDelimiter({ selected: ',' });
+        expect(widget.isDisposed).to.be(false);
+        widget.dispose();
+        widget.dispose();
+        expect(widget.isDisposed).to.be(true);
       });
 
     });