Steven Silvester 6 years ago
parent
commit
891107feb4
5 changed files with 6 additions and 3 deletions
  1. 1 1
      .eslintrc
  2. 2 1
      examples/chrome-example-test.js
  3. 1 0
      jupyterlab/browser_check.py
  4. 1 0
      jupyterlab/chrome-test.js
  5. 1 1
      package.json

+ 1 - 1
.eslintrc

@@ -7,7 +7,7 @@
   "extends": ["eslint:recommended", "prettier"],
   "plugins": ["prettier"],
   "parserOptions": {
-    "ecmaVersion": 6,
+    "ecmaVersion": 2017,
     "sourceType": "module",
     "ecmaFeatures": {
       "modules": true,

+ 2 - 1
examples/chrome-example-test.js

@@ -8,6 +8,7 @@ const inspect = require('util').inspect;
 const URL = process.argv[2];
 
 async function main() {
+  /* eslint-disable no-console */
   console.info('Starting Chrome Headless');
 
   // Disable shm usage to save resources and prevent random memory
@@ -17,7 +18,7 @@ async function main() {
   });
   const page = await browser.newPage();
 
-  errored = false;
+  let errored = false;
 
   const handleMessage = async msg => {
     const text = msg.text();

+ 1 - 0
jupyterlab/browser_check.py

@@ -5,6 +5,7 @@ This module is meant to run JupyterLab in a headless browser, making sure
 the application launches and starts up without errors.
 """
 from concurrent.futures import ThreadPoolExecutor
+import logging
 from os import path as osp
 import os
 import shutil

+ 1 - 0
jupyterlab/chrome-test.js

@@ -3,6 +3,7 @@ const inspect = require('util').inspect;
 const URL = process.argv[2];
 
 async function main() {
+  /* eslint-disable no-console */
   console.info('Starting Chrome Headless');
 
   const browser = await puppeteer.launch({ args: ['--no-sandbox'] });

+ 1 - 1
package.json

@@ -66,7 +66,7 @@
     "test": "lerna run test --scope \"@jupyterlab/test-*\" --concurrency 1 --stream",
     "test:chrome": "lerna run test:chrome --scope \"@jupyterlab/test-*\" --concurrency 1 --stream",
     "test:chrome-headless": "lerna run test:chrome-headless --scope \"@jupyterlab/test-*\" --concurrency 1 --stream",
-    "test:examples": "python examples/test_examples.py",
+    "test:examples": "python examples/test_examples.py --concurrency 1",
     "test:firefox": "lerna run test:firefox --scope \"@jupyterlab/test-*\" --concurrency 1 --stream",
     "test:ie": "lerna run test:ie --scope \"@jupyterlab/test-*\" --concurrency 1 --stream",
     "tslint": "tslint --fix -c tslint.json --project tsconfigbase.json '**/*{.ts,.tsx}'",