瀏覽代碼

fix example error handling and update app example

Steven Silvester 6 年之前
父節點
當前提交
960dbe3984
共有 3 個文件被更改,包括 10 次插入6 次删除
  1. 2 0
      examples/app/index.js
  2. 1 0
      examples/app/package.json
  3. 7 6
      examples/chrome-example-test.js

+ 2 - 0
examples/app/index.js

@@ -34,6 +34,7 @@ window.addEventListener('load', function() {
     require('@jupyterlab/running-extension'),
     require('@jupyterlab/settingeditor-extension'),
     require('@jupyterlab/shortcuts-extension'),
+    require('@jupyterlab/statusbar-extension'),
     require('@jupyterlab/tabmanager-extension'),
     require('@jupyterlab/terminal-extension'),
     require('@jupyterlab/theme-dark-extension'),
@@ -46,6 +47,7 @@ window.addEventListener('load', function() {
     version: require('./package.json').version
   });
   lab.registerPluginModules(mods);
+  console.log('what');
   lab.start().then(() => {
     // eslint-disable-next-line
     console.log('Example started!');

+ 1 - 0
examples/app/package.json

@@ -32,6 +32,7 @@
     "@jupyterlab/running-extension": "^1.0.0-alpha.6",
     "@jupyterlab/settingeditor-extension": "^1.0.0-alpha.6",
     "@jupyterlab/shortcuts-extension": "^1.0.0-alpha.6",
+    "@jupyterlab/statusbar-extension": "^1.0.0-alpha.6",
     "@jupyterlab/tabmanager-extension": "^1.0.0-alpha.6",
     "@jupyterlab/terminal-extension": "^1.0.0-alpha.6",
     "@jupyterlab/theme-dark-extension": "^1.0.0-alpha.7",

+ 7 - 6
examples/chrome-example-test.js

@@ -17,23 +17,20 @@ async function main() {
   });
   const page = await browser.newPage();
 
-  console.info('Navigating to page:', URL);
-  await page.goto(URL);
-  console.info('Waiting for page to load...');
-
   errored = false;
 
   const handleMessage = async msg => {
     const text = msg.text();
     console.log(`>> ${text}`);
-    if (msg.type === 'error') {
+    if (msg.type() === 'error') {
       errored = true;
     }
     const lower = text.toLowerCase();
     if (lower === 'example started!' || lower === 'test complete!') {
       await browser.close();
       if (errored) {
-        throw Error('Example test failed!');
+        console.error('\n\n***\nExample test failed!\n***\n\n');
+        process.exit(1);
       }
       console.info('Example test complete!');
       return;
@@ -48,6 +45,10 @@ async function main() {
   page.on('console', handleMessage);
   page.on('error', handleError);
 
+  console.info('Navigating to page:', URL);
+  await page.goto(URL);
+  console.info('Waiting for page to load...');
+
   const html = await page.content();
   if (inspect(html).indexOf('jupyter-config-data') === -1) {
     console.error('Error loading JupyterLab page:');