Pārlūkot izejas kodu

Merge pull request #1577 from blink1073/fix-running-windows

Fix running tab console error and faq command id usage
Steven Silvester 8 gadi atpakaļ
vecāks
revīzija
967c5d2e15
2 mainītis faili ar 8 papildinājumiem un 1 dzēšanām
  1. 5 1
      src/faq/widget.ts
  2. 3 0
      src/running/index.ts

+ 5 - 1
src/faq/widget.ts

@@ -9,6 +9,10 @@ import {
   h, VNode
 } from 'phosphor/lib/ui/vdom';
 
+import {
+  CommandIDs as AboutCommandIDs
+} from '../about';
+
 import {
   ICommandLinker
 } from '../commandlinker';
@@ -263,7 +267,7 @@ class FaqWidget extends VDomWidget<FaqModel> {
           'Check out the JupyterLab tour ',
           h.a(this._linker.populateVNodeAttrs({
             className: ANCHOR_CLASS
-          }, 'about-jupyterlab:show', null), 'here')
+          }, AboutCommandIDs.open, null), 'here')
         )
       ),
       h.h2({ className: SUBHEADER_CLASS }, subheadings[1]),

+ 3 - 0
src/running/index.ts

@@ -250,6 +250,9 @@ class RunningSessions extends Widget {
     let renderer = this._renderer;
     let specs = this._manager.specs;
 
+    // Create a dummy div if terminals are not available.
+    termList = termList || document.createElement('div');
+
     // Remove any excess item nodes.
     while (termList.children.length > this._runningTerminals.length) {
       termList.removeChild(termList.firstChild);