Steven Silvester 4 years ago
parent
commit
968b3ecbfa

+ 1 - 1
.github/workflows/windowstests.yml

@@ -7,7 +7,7 @@ jobs:
     name: Windows
     strategy:
       matrix:
-        group: [integrity, integrity2, usage, python, examples, docs]
+        group: [integrity, python]
       fail-fast: false
     runs-on: windows-latest
     steps:

+ 1 - 1
jupyterlab/commands.py

@@ -635,7 +635,7 @@ class _AppHandler(object):
         # FIXME: part of https://github.com/jupyterlab/jupyterlab/issues/8655
         if command == None:
             if os.name == 'nt':
-                command = 'build'
+                command = 'build:dev'
             else:
                 command = 'build:prod:minimize'
 

+ 4 - 0
jupyterlab/labextensions.py

@@ -106,6 +106,10 @@ class BaseExtensionApp(JupyterApp, DebugLogFileMixin):
             ans = self.run_task()
             if ans and self.should_build:
                 parts = ['build']
+                # FIXME: part of https://github.com/jupyterlab/jupyterlab/issues/8655
+                if os.name == 'nt':
+                    self.dev_build = True
+                    self.minimize = False
                 parts.append('none' if self.dev_build is None else
                              'dev' if self.dev_build else
                              'prod')

+ 1 - 1
packages/debugger/src/svg.d.ts

@@ -1,4 +1,4 @@
 declare module '*.svg' {
-  const value: string;
+  const value: string; // @ts-ignore
   export default value;
 }

+ 5 - 5
packages/translation/src/gettext.ts

@@ -572,15 +572,15 @@ class Gettext {
       plural = options.pluralFunc(n);
 
       // if plural form never interpreted before, do it now and store it
-    } else if (!this._pluralFuncs[options.locale]) {
-      this._pluralFuncs[options.locale] = this.getPluralFunc(
-        this._pluralForms[options.locale]
+    } else if (!this._pluralFuncs[options.locale || '']) {
+      this._pluralFuncs[options.locale || ''] = this.getPluralFunc(
+        this._pluralForms[options.locale || '']
       );
-      plural = this._pluralFuncs[options.locale](n);
+      plural = this._pluralFuncs[options.locale || ''](n);
 
       // we have the plural function, compute the plural result
     } else {
-      plural = this._pluralFuncs[options.locale](n);
+      plural = this._pluralFuncs[options.locale || ''](n);
     }
 
     // If there is a problem with plurals, fallback to singular one

+ 1 - 1
packages/ui-components/src/svg.d.ts

@@ -8,7 +8,7 @@
 // The svg will be imported as a raw string
 
 declare module '*.svg' {
-  const value: string;
+  const value: string; // @ts-ignore
   export default value;
 }