Delete read-only checks, which are done at compile time for Typescript 2.0.

test/src/common/activitymonitor.spec.ts

@@ -168,11 +168,6 @@ describe('common/activitymonitor', () => {
         expect(monitor.isDisposed).to.be(true);
       });
 
-      it('should be read-only', () => {
-        let monitor = new ActivityMonitor<TestObject, number>({ signal });
-        expect(() => { (monitor as any).isDisposed = false; }).to.throwError();
-      });
-
     });
 
     describe('#dispose()', () => {

test/src/common/observablelist.spec.ts

@@ -104,11 +104,6 @@ describe('common/observablelist', () => {
         expect(list.length).to.be(1);
       });
 
-      it('should be read-only', () => {
-        let list = new ObservableList<number>();
-        expect(() => { (list as any).length = 2; }).to.throwError();
-      });
-
     });
 
     describe('#get()', () => {

test/src/console/history.spec.ts

@@ -69,11 +69,6 @@ describe('console/history', () => {
         expect(history.isDisposed).to.be(true);
       });
 
-      it('should be read-only', () => {
-        let history = new ConsoleHistory();
-        expect(() => (history as any).isDisposed = false).to.throwError();
-      });
-
     });
 
     describe('#kernel', () => {

test/src/docregistry/default.spec.ts

@@ -42,11 +42,6 @@ describe('docmanager/default', () => {
         expect(factory.isDisposed).to.be(true);
       });
 
-      it('should be read-only', () => {
-        let factory = new WidgetFactory();
-        expect(() => { (factory as any).isDisposed = false; }).to.throwError();
-      });
-
     });
 
     describe('#dispose()', () => {
@@ -89,11 +84,6 @@ describe('docmanager/default', () => {
         expect(factory.name).to.be('base64');
       });
 
-      it('should be read-only', () => {
-        let factory = new Base64ModelFactory();
-        expect(() => { (factory as any).name = ''; }).to.throwError();
-      });
-
     });
 
     describe('#type', () => {
@@ -103,11 +93,6 @@ describe('docmanager/default', () => {
         expect(factory.fileType).to.be('file');
       });
 
-      it('should be read-only', () => {
-        let factory = new Base64ModelFactory();
-        expect(() => { (factory as any).fileType = 'file'; }).to.throwError();
-      });
-
     });
 
     describe('#format', () => {
@@ -117,11 +102,6 @@ describe('docmanager/default', () => {
         expect(factory.fileFormat).to.be('base64');
       });
 
-      it('should be read-only', () => {
-        let factory = new Base64ModelFactory();
-        expect(() => { (factory as any).fileFormat = 'base64'; }).to.throwError();
-      });
-
     });
 
   });
@@ -151,11 +131,6 @@ describe('docmanager/default', () => {
         expect(model.isDisposed).to.be(true);
       });
 
-      it('should be read-only', () => {
-        let model = new DocumentModel();
-        expect(() => { (model as any).isDisposed = false; }).to.throwError();
-      });
-
     });
 
     describe('#contentChanged', () => {
@@ -277,11 +252,6 @@ describe('docmanager/default', () => {
         expect(model.defaultKernelName).to.be('');
       });
 
-      it('should be read-only', () => {
-        let model = new DocumentModel();
-        expect(() => { (model as any).defaultKernelName = ''; }).to.throwError();
-      });
-
     });
 
     describe('defaultKernelLanguage', () => {
@@ -296,11 +266,6 @@ describe('docmanager/default', () => {
         expect(model.defaultKernelLanguage).to.be('foo');
       });
 
-      it('should be read-only', () => {
-        let model = new DocumentModel();
-        expect(() => { (model as any).defaultKernelLanguage = ''; }).to.throwError();
-      });
-
     });
 
     describe('#dispose()', () => {
@@ -369,11 +334,6 @@ describe('docmanager/default', () => {
         expect(factory.name).to.be('text');
       });
 
-      it('should be read-only', () => {
-        let factory = new TextModelFactory();
-        expect(() => { (factory as any).name = ''; }).to.throwError();
-      });
-
     });
 
     describe('#type', () => {
@@ -383,11 +343,6 @@ describe('docmanager/default', () => {
         expect(factory.fileType).to.be('file');
       });
 
-      it('should be read-only', () => {
-        let factory = new TextModelFactory();
-        expect(() => { (factory as any).fileType = 'file'; }).to.throwError();
-      });
-
     });
 
     describe('#format', () => {
@@ -397,11 +352,6 @@ describe('docmanager/default', () => {
         expect(factory.fileFormat).to.be('text');
       });
 
-      it('should be read-only', () => {
-        let factory = new TextModelFactory();
-        expect(() => { (factory as any).fileFormat = 'text'; }).to.throwError();
-      });
-
     });
 
     describe('#isDisposed', () => {
@@ -413,11 +363,6 @@ describe('docmanager/default', () => {
         expect(factory.isDisposed).to.be(true);
       });
 
-      it('should be read-only', () => {
-        let factory = new TextModelFactory();
-        expect(() => { (factory as any).isDisposed = false; }).to.throwError();
-      });
-
     });
 
     describe('#dispose()', () => {

test/src/docregistry/registry.spec.ts

@@ -59,10 +59,6 @@ describe('docregistry/registry', () => {
         expect(registry.isDisposed).to.be(true);
       });
 
-      it('should be read-only', () => {
-        expect(() => { (registry as any).isDisposed = false; }).to.throwError();
-      });
-
     });
 
     describe('#dispose()', () => {

test/src/notebook/cells/widget.spec.ts

@@ -241,13 +241,6 @@ describe('notebook/cells/widget', () => {
         expect(widget.editor).to.be.a(CodeMirrorCellEditorWidget);
       });
 
-      it('should be read-only', () => {
-        let widget = new BaseCellWidget({
-          renderer: CodeMirrorCodeCellWidgetRenderer.defaultRenderer
-        });
-        expect(() => { (widget as any).editor = null; }).to.throwError();
-      });
-
     });
 
     describe('#mimetype', () => {

test/src/notebook/notebook/model.spec.ts

@@ -119,11 +119,6 @@ describe('notebook/notebook/model', () => {
         expect(model.cells.get(1)).to.not.be(cell);  // should be a clone.
       });
 
-      it('should be read-only', () => {
-        let model = new NotebookModel();
-        expect(() => { (model as any).cells = null; }).to.throwError();
-      });
-
       context('cells `changed` signal', () => {
 
         it('should emit a `contentChanged` signal', () => {
@@ -202,11 +197,6 @@ describe('notebook/notebook/model', () => {
         expect(model.factory).to.be(NotebookModel.defaultFactory);
       });
 
-      it('should be read-only', () => {
-        let model = new NotebookModel();
-        expect(() => { (model as any).factory = null; }).to.throwError();
-      });
-
       context('createCodeCell()', () => {
 
         it('should create a new code cell', () => {
@@ -295,11 +285,6 @@ describe('notebook/notebook/model', () => {
         expect(model.nbformat).to.be(DEFAULT_CONTENT.nbformat);
       });
 
-      it('should be read-only', () => {
-        let model = new NotebookModel();
-        expect(() => { (model as any).nbformat = 0; }).to.throwError();
-      });
-
     });
 
     describe('#nbformatMinor', () => {
@@ -310,11 +295,6 @@ describe('notebook/notebook/model', () => {
         expect(model.nbformatMinor).to.be(DEFAULT_CONTENT.nbformat_minor);
       });
 
-      it('should be read-only', () => {
-        let model = new NotebookModel();
-        expect(() => { (model as any).nbformatMinor = 0; }).to.throwError();
-      });
-
     });
 
     describe('#defaultKernelName()', () => {
@@ -330,11 +310,6 @@ describe('notebook/notebook/model', () => {
         expect(model.defaultKernelName).to.be('');
       });
 
-      it('should be read-only', () => {
-        let model = new NotebookModel();
-        expect(() => { (model as any).defaultKernelName = ''; }).to.throwError();
-      });
-
     });
 
     describe('#defaultKernelLanguage', () => {
@@ -355,11 +330,6 @@ describe('notebook/notebook/model', () => {
         expect(model.defaultKernelLanguage).to.be('foo');
       });
 
-      it('should be read-only', () => {
-        let model = new NotebookModel();
-        expect(() => { (model as any).defaultKernelLanguage = ''; }).to.throwError();
-      });
-
     });
 
     describe('#dispose()', () => {

test/src/notebook/notebook/modelfactory.spec.ts

@@ -23,11 +23,6 @@ describe('notebook/notebook/modelfactory', () => {
         expect(factory.name).to.be('notebook');
       });
 
-      it('should be read-only', () => {
-        let factory = new NotebookModelFactory();
-        expect(() => { (factory as any).name = ''; }).to.throwError();
-      });
-
     });
 
     describe('#type', () => {
@@ -37,11 +32,6 @@ describe('notebook/notebook/modelfactory', () => {
         expect(factory.fileType).to.be('notebook');
       });
 
-      it('should be read-only', () => {
-        let factory = new NotebookModelFactory();
-        expect(() => { (factory as any).fileType = 'notebook'; }).to.throwError();
-      });
-
     });
 
     describe('#format', () => {
@@ -51,11 +41,6 @@ describe('notebook/notebook/modelfactory', () => {
         expect(factory.fileFormat).to.be('json');
       });
 
-      it('should be read-only', () => {
-        let factory = new NotebookModelFactory();
-        expect(() => { (factory as any).fileFormat = 'json'; }).to.throwError();
-      });
-
     });
 
     describe('#isDisposed', () => {
@@ -67,11 +52,6 @@ describe('notebook/notebook/modelfactory', () => {
         expect(factory.isDisposed).to.be(true);
       });
 
-      it('should be read-only', () => {
-        let factory = new NotebookModelFactory();
-        expect(() => { (factory as any).isDisposed = false; }).to.throwError();
-      });
-
     });
 
     describe('#dispose()', () => {

test/src/notebook/notebook/panel.spec.ts

@@ -172,11 +172,6 @@ describe('notebook/notebook/panel', () => {
         expect(panel.toolbar).to.be.a(Toolbar);
       });
 
-      it('should be read-only', () => {
-        let panel = new NotebookPanel({ rendermime, clipboard, renderer });
-        expect(() => { (panel as any).toolbar = null; }).to.throwError();
-      });
-
     });
 
     describe('#content', () => {
@@ -186,11 +181,6 @@ describe('notebook/notebook/panel', () => {
         expect(panel.content).to.be.a(Notebook);
       });
 
-      it('should be read-only', () => {
-        let panel = new NotebookPanel({ rendermime, clipboard, renderer });
-        expect(() => { (panel as any).content = null; }).to.throwError();
-      });
-
     });
 
     describe('#kernel', () => {
@@ -202,11 +192,6 @@ describe('notebook/notebook/panel', () => {
         expect(panel.kernel.name).to.be('shell');
       });
 
-      it('should be read-only', () => {
-        let panel = new NotebookPanel({ rendermime, clipboard, renderer });
-        expect(() => { (panel as any).kernel = null; }).to.throwError();
-      });
-
     });
 
     describe('#rendermime', () => {
@@ -216,11 +201,6 @@ describe('notebook/notebook/panel', () => {
         expect(panel.rendermime).to.be(rendermime);
       });
 
-      it('should be read-only', () => {
-        let panel = new NotebookPanel({ rendermime, clipboard, renderer });
-        expect(() => { (panel as any).rendermime = null; }).to.throwError();
-      });
-
     });
 
     describe('#renderer', () => {
@@ -231,11 +211,6 @@ describe('notebook/notebook/panel', () => {
         expect(panel.renderer).to.be(renderer);
       });
 
-      it('should be read-only', () => {
-        let panel = new NotebookPanel({ rendermime, clipboard, renderer });
-        expect(() => { (panel as any).renderer = null; });
-      });
-
     });
 
     describe('#clipboard', () => {
@@ -245,11 +220,6 @@ describe('notebook/notebook/panel', () => {
         expect(panel.clipboard).to.be(clipboard);
       });
 
-      it('should be read-only', () => {
-        let panel = new NotebookPanel({ rendermime, clipboard, renderer });
-        expect(() => { (panel as any).clipboard = null; }).to.throwError();
-      });
-
     });
 
     describe('#model', () => {
@@ -264,11 +234,6 @@ describe('notebook/notebook/panel', () => {
         expect(panel.content.model).to.be(model);
       });
 
-      it('should be read-only', () => {
-        let panel = new NotebookPanel({ rendermime, clipboard, renderer });
-        expect(() => { (panel as any).model = null; }).to.throwError();
-      });
-
     });
 
     describe('#context', () => {

test/src/notebook/notebook/widget.spec.ts

@@ -333,11 +333,6 @@ describe('notebook/notebook/widget', () => {
         expect(widget.rendermime).to.be(rendermime);
       });
 
-      it('should be read-only', () => {
-        let widget = createWidget();
-        expect(() => { (widget as any).rendermime = null; }).to.throwError();
-      });
-
     });
 
     describe('#renderer', () => {
@@ -347,11 +342,6 @@ describe('notebook/notebook/widget', () => {
         expect(widget.renderer).to.be(CodeMirrorNotebookRenderer.defaultRenderer);
       });
 
-      it('should be read-only', () => {
-        let widget = createWidget();
-        expect(() => { (widget as any).renderer = null; }).to.throwError();
-      });
-
     });
 
     describe('#codeMimetype', () => {
@@ -813,11 +803,6 @@ describe('notebook/notebook/widget', () => {
         expect(widget.activeCell).to.be(widget.childAt(0));
       });
 
-      it('should be read-only', () => {
-        let widget = createActiveWidget();
-        expect(() => { (widget as any).activeCell = null; }).to.throwError();
-      });
-
     });
 
     describe('#select()', () => {

test/src/notebook/notebook/widgetfactory.spec.ts

@@ -59,11 +59,6 @@ describe('notebook/notebook/widgetfactory', () => {
         expect(factory.isDisposed).to.be(true);
       });
 
-      it('should be read-only', () => {
-        let factory = new NotebookWidgetFactory(rendermime, clipboard, renderer);
-        expect(() => { (factory as any).isDisposed = false; }).to.throwError();
-      });
-
     });
 
     describe('#dispose()', () => {

test/src/notebook/output-area/model.spec.ts

@@ -111,11 +111,6 @@ describe('notebook/output-area/model', () => {
         expect(model.length).to.be(1);
       });
 
-      it('should be read-only', () => {
-        let model = new OutputAreaModel();
-        expect(() => { (model as any).length = 0; }).to.throwError();
-      });
-
     });
 
     describe('#isDisposed', () => {
@@ -127,11 +122,6 @@ describe('notebook/output-area/model', () => {
         expect(model.isDisposed).to.be(true);
       });
 
-      it('should be read-only', () => {
-        let model = new OutputAreaModel();
-        expect(() => { (model as any).isDisposed = true; }).to.throwError();
-      });
-
     });
 
     describe('#dispose()', () => {

test/src/notebook/output-area/widget.spec.ts

@@ -188,11 +188,6 @@ describe('notebook/output-area/widget', () => {
         expect(widget.rendermime).to.be(rendermime);
       });
 
-      it('should be read-only', () => {
-        let widget = new OutputAreaWidget({ rendermime });
-        expect(() => { (widget as any).rendermime = null; }).to.throwError();
-      });
-
     });
 
     describe('#renderer', () => {
@@ -203,11 +198,6 @@ describe('notebook/output-area/widget', () => {
         expect(widget.renderer).to.be(renderer);
       });
 
-      it('should be read-only', () => {
-        let widget = new OutputAreaWidget({ rendermime });
-        expect(() => { (widget as any).renderer = null; }).to.throwError();
-      });
-
     });
 
     describe('#trusted', () => {
@@ -393,11 +383,6 @@ describe('notebook/output-area/widget', () => {
         expect(widget.prompt.hasClass('jp-Output-prompt')).to.be(true);
       });
 
-      it('should be read-only', () => {
-        let widget = new OutputWidget({ rendermime });
-        expect(() => { (widget as any).prompt = null; }).to.throwError();
-      });
-
     });
 
     describe('#output', () => {
@@ -407,11 +392,6 @@ describe('notebook/output-area/widget', () => {
         expect(widget.output.hasClass('jp-Output-result')).to.be(true);
       });
 
-      it('should be read-only', () => {
-        let widget = new OutputWidget({ rendermime });
-        expect(() => { (widget as any).output = null; }).to.throwError();
-      });
-
     });
 
     describe('#clear()', () => {