Browse Source

Add node dependencies and a browser field to services for the ws and node-fetch packages

Webpack should ignore our import of the ws and node-fetch nodejs packages because of the browser field (see https://github.com/defunctzombie/package-browser-field-spec#ignore-a-module).

Fixes #5856
Jason Grout 6 years ago
parent
commit
a35219b5a5
2 changed files with 17 additions and 1 deletions
  1. 7 1
      packages/services/package.json
  2. 10 0
      yarn.lock

+ 7 - 1
packages/services/package.json

@@ -42,7 +42,9 @@
     "@phosphor/algorithm": "^1.1.2",
     "@phosphor/algorithm": "^1.1.2",
     "@phosphor/coreutils": "^1.3.0",
     "@phosphor/coreutils": "^1.3.0",
     "@phosphor/disposable": "^1.1.2",
     "@phosphor/disposable": "^1.1.2",
-    "@phosphor/signaling": "^1.2.2"
+    "@phosphor/signaling": "^1.2.2",
+    "node-fetch": "^2.3.0",
+    "ws": "^6.1.3"
   },
   },
   "devDependencies": {
   "devDependencies": {
     "@types/node": "~8.0.47",
     "@types/node": "~8.0.47",
@@ -54,6 +56,10 @@
     "webpack": "~4.12.0",
     "webpack": "~4.12.0",
     "webpack-cli": "^3.0.3"
     "webpack-cli": "^3.0.3"
   },
   },
+  "browser": {
+    "node-fetch": false,
+    "ws": false
+  },
   "publishConfig": {
   "publishConfig": {
     "access": "public"
     "access": "public"
   },
   },

+ 10 - 0
yarn.lock

@@ -6989,6 +6989,10 @@ node-fetch@^2.1.2, node-fetch@~2.2.0:
   version "2.2.0"
   version "2.2.0"
   resolved "https://registry.npmjs.org/node-fetch/-/node-fetch-2.2.0.tgz#4ee79bde909262f9775f731e3656d0db55ced5b5"
   resolved "https://registry.npmjs.org/node-fetch/-/node-fetch-2.2.0.tgz#4ee79bde909262f9775f731e3656d0db55ced5b5"
 
 
+node-fetch@^2.3.0:
+  version "2.3.0"
+  resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.3.0.tgz#1a1d940bbfb916a1d3e0219f037e89e71f8c5fa5"
+
 node-gyp@^3.8.0:
 node-gyp@^3.8.0:
   version "3.8.0"
   version "3.8.0"
   resolved "https://registry.yarnpkg.com/node-gyp/-/node-gyp-3.8.0.tgz#540304261c330e80d0d5edce253a68cb3964218c"
   resolved "https://registry.yarnpkg.com/node-gyp/-/node-gyp-3.8.0.tgz#540304261c330e80d0d5edce253a68cb3964218c"
@@ -10771,6 +10775,12 @@ ws@^5.1.1, ws@^5.2.0:
   dependencies:
   dependencies:
     async-limiter "~1.0.0"
     async-limiter "~1.0.0"
 
 
+ws@^6.1.3:
+  version "6.1.3"
+  resolved "https://registry.yarnpkg.com/ws/-/ws-6.1.3.tgz#d2d2e5f0e3c700ef2de89080ebc0ac6e1bf3a72d"
+  dependencies:
+    async-limiter "~1.0.0"
+
 ws@~3.3.1:
 ws@~3.3.1:
   version "3.3.3"
   version "3.3.3"
   resolved "https://registry.yarnpkg.com/ws/-/ws-3.3.3.tgz#f1cf84fe2d5e901ebce94efaece785f187a228f2"
   resolved "https://registry.yarnpkg.com/ws/-/ws-3.3.3.tgz#f1cf84fe2d5e901ebce94efaece785f187a228f2"