Browse Source

Add an optional ‘path’ argument to the filebrowser openPath command

Jason Grout 5 years ago
parent
commit
a3885b4377

+ 1 - 1
packages/application-extension/src/index.tsx

@@ -277,7 +277,7 @@ const tree: JupyterFrontEndPlugin<void> = {
         router.navigate(url);
 
         try {
-          await commands.execute('filebrowser:go-to-path', { path });
+          await commands.execute('filebrowser:open-path', { path });
           await commands.execute('apputils:save-statedb', { immediate });
         } catch (error) {
           console.warn('Tree routing failed.', error);

+ 11 - 9
packages/filebrowser-extension/src/index.ts

@@ -448,15 +448,17 @@ function addCommands(
   });
 
   commands.addCommand(CommandIDs.openPath, {
-    label: 'Open From Path…',
-    caption: 'Open from path',
-    execute: async () => {
-      let { value: path } = await InputDialog.getText({
-        label: 'Path',
-        placeholder: '/path/relative/to/jlab/root',
-        title: 'Open Path',
-        okLabel: 'Open'
-      });
+    label: args => (args.path ? `Open ${args.path}` : 'Open From Path…'),
+    caption: args => (args.path ? `Open ${args.path}` : 'Open from path'),
+    execute: async ({ path }: { path?: string }) => {
+      if (!path) {
+        path = (await InputDialog.getText({
+          label: 'Path',
+          placeholder: '/path/relative/to/jlab/root',
+          title: 'Open Path',
+          okLabel: 'Open'
+        })).value;
+      }
       if (!path) {
         return;
       }