Browse Source

Fix update snapshot for 3.4.x (#12462)

Frédéric Collonval 3 years ago
parent
commit
a9db867ad3
2 changed files with 3 additions and 45 deletions
  1. 0 45
      .github/workflows/galata-update.yml
  2. 3 0
      galata/package.json

+ 0 - 45
.github/workflows/galata-update.yml

@@ -1,45 +0,0 @@
-name: Update Playwright Snapshots
-
-on:
-  issue_comment:
-    types: [created, edited]
-
-permissions:
-  contents: write
-  pull-requests: write
-
-jobs:
-  update-galata-snapshots:
-    name: Update Galata References
-    if: ${{ github.event.issue.pull_request && (contains(github.event.comment.body, 'please update galata snapshots') || contains(github.event.comment.body, 'please update snapshots')) }}
-    timeout-minutes: 80
-    runs-on: ubuntu-20.04
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v2
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: Configure git to use https
-        run: git config --global hub.protocol https
-
-      - name: Checkout the branch from the PR that triggered the job
-        run: hub pr checkout ${{ github.event.issue.number }}
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: Base Setup
-        uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
-
-      - name: Install dependencies
-        run: |
-          bash ./scripts/ci_install.sh
-          # Build dev-mode
-          jlpm run build
-
-      - uses: jupyterlab/maintainer-tools/.github/actions/update-snapshots@v1
-        with:
-          github_token: ${{ secrets.GITHUB_TOKEN }}
-          server_url: http-get://localhost:8888/lab
-          test_folder: galata

+ 3 - 0
galata/package.json

@@ -36,10 +36,13 @@
     "clean": "rimraf lib tsconfig.tsbuildinfo",
     "start": "jupyter lab --config ./jupyter_server_test_config.py",
     "start:detached": "(jlpm run start&)",
+    "start:doc": "mkdir -p /tmp/dummy-server/lab && python -m http.server -d /tmp/dummy-server 8888",
     "test": "playwright test",
     "test:benchmark": "jlpm run test -c playwright-benchmark.config.js",
     "test:benchmark:update": "BENCHMARK_NUMBER_SAMPLES=1 jlpm run test -c playwright-benchmark.config.js --update-snapshots",
     "test:debug": "PWDEBUG=1 playwright test",
+    "test:doc": "echo \"No documentation tests\"",
+    "test:doc:update": "echo \"No documentation tests\"",
     "test:report": "http-server ./playwright-report -a localhost -o",
     "test:update": "playwright test --update-snapshots && jlpm test:benchmark:update"
   },