Ver código fonte

Update session and session manager test

Steven Silvester 7 anos atrás
pai
commit
beb90c43de

+ 2 - 4
packages/services/src/session/default.ts

@@ -281,10 +281,8 @@ class DefaultSession implements Session.ISession {
       return Promise.reject(new Error('Session is disposed'));
     }
     let data = JSON.stringify({ kernel: options });
-    if (this._kernel) {
-      this._kernel.dispose();
-      this._statusChanged.emit('restarting');
-    }
+    this._kernel.dispose();
+    this._statusChanged.emit('restarting');
     return this._patch(data).then(() => this.kernel);
   }
 

+ 8 - 4
packages/services/test/src/session/manager.spec.ts

@@ -131,8 +131,9 @@ describe('session/manager', () => {
         handleRequest(manager, 200, specs);
         manager.specsChanged.connect((sender, args) => {
           expect(sender).to.be(manager);
-          expect(args.default).to.be(specs.default);
-          done();
+          if (args.default === specs.default) {
+            done();
+          }
         });
         manager.refreshSpecs();
       });
@@ -185,6 +186,8 @@ describe('session/manager', () => {
           called = true;
         });
         return session.changeKernel({ name: session.kernel.name }).then(() => {
+          return manager.refreshRunning();
+        }).then(() => {
           expect(called).to.be(true);
         });
       });
@@ -286,8 +289,9 @@ describe('session/manager', () => {
         let called = false;
         return startNew(manager).then(s => {
           manager.runningChanged.connect((sender, args) => {
-            expect(s.isDisposed).to.be(true);
-            called = true;
+            if (s.isDisposed) {
+              called = true;
+            }
           });
           return manager.shutdown(s.id);
         }).then(() => {