浏览代码

Backport PR #12480: Only show duplicate LabIcon warning in debug mode (#12481)

Co-authored-by: Alex Bozarth <ajbozart@us.ibm.com>
MeeseeksMachine 3 年之前
父节点
当前提交
c394aa25d1
共有 1 个文件被更改,包括 5 次插入4 次删除
  1. 5 4
      packages/ui-components/src/icon/labicon.tsx

+ 5 - 4
packages/ui-components/src/icon/labicon.tsx

@@ -237,10 +237,11 @@ export class LabIcon implements LabIcon.ILabIcon, VirtualElement.IRenderer {
         return icon;
       } else {
         // already loaded icon svg exists; replace it and warn
-        // TODO: need to see if this warning is useful or just noisy
-        console.warn(
-          `Redefining previously loaded icon svgstr. name: ${name}, svgstrOld: ${icon.svgstr}, svgstr: ${svgstr}`
-        );
+        if (LabIcon._debug) {
+          console.warn(
+            `Redefining previously loaded icon svgstr. name: ${name}, svgstrOld: ${icon.svgstr}, svgstr: ${svgstr}`
+          );
+        }
         icon.svgstr = svgstr;
         return icon;
       }