Ver código fonte

Merge pull request #9019 from goanpeca/fix/builder-path-quoting

PR: Fix builder path quoting
Jason Grout 4 anos atrás
pai
commit
c417fb5984

+ 1 - 1
builder/src/build-labextension.ts

@@ -36,7 +36,7 @@ commander
 
     const webpack = require.resolve('webpack-cli/bin/cli.js');
     const config = path.join(__dirname, 'webpack.config.ext.js');
-    let cmdText = `node ${webpack} --config ${config} --mode ${mode}`;
+    let cmdText = `node "${webpack}" --config "${config}" --mode ${mode}`;
     if (cmd.watch) {
       cmdText += ' --watch';
     }

+ 4 - 5
docs/source/developer/extension_tutorial.rst

@@ -63,7 +63,7 @@ new environment named ``jupyterlab-ext``.
 
 .. code:: bash
 
-    conda create -n jupyterlab-ext --override-channels --strict-channel-priority -c conda-forge -c anaconda jupyterlab cookiecutter nodejs git
+    conda create -n jupyterlab-ext --override-channels --strict-channel-priority -c conda-forge -c anaconda cookiecutter nodejs git
 
 Now activate the new environment so that all further commands you run
 work out of that environment.
@@ -76,12 +76,11 @@ Note: You'll need to run the command above in each new terminal you open
 before you can work with the tools you installed in the
 ``jupyterlab-ext`` environment.
 
-Note: if you have an older version of JupyterLab previously installed, you may need to update
-the version of JupyterLab manually.
+Now we can install the latest version of JupyterLab.
 
 .. code:: bash
 
-    conda install -c conda-forge jupyterlab=2
+    pip install jupyterlab --pre
 
 Create a repository
 ~~~~~~~~~~~~~~~~~~~
@@ -102,7 +101,7 @@ This will create a new folder for your extension in your current directory.
 
 .. code:: bash
 
-    cookiecutter https://github.com/jupyterlab/extension-cookiecutter-ts
+    cookiecutter https://github.com/jupyterlab/extension-cookiecutter-ts --checkout 3.0
 
 When prompted, enter values like the following for all of the cookiecutter
 prompts (``apod`` stands for Astronomy Picture of the Day, the NASA service we

+ 2 - 2
docs/source/user/language.rst

@@ -19,7 +19,7 @@ Installing
 ''''''''''
 
 Language packs are identified by the four letter code of the language and
-variante they provide. For example, for Simplified Chinese the language
+variant they provide. For example, for Simplified Chinese the language
 pack code is ``zh-CN`` and you can install it with ``conda`` or ``pip``.
 
 If you use conda with conda-forge packages:
@@ -40,7 +40,7 @@ Changing the display language
 To change the interface language, select the Settings menu and then
 select the desired language in the Language submenu.
 
-The Language submenu will inly list any previously installed language
+The Language submenu will only list any previously installed language
 packs.
 
 .. image:: images/language_settings.png