Browse Source

Backport PR #11032: Make debugger jest test more robust (#11044)

Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
MeeseeksMachine 3 years ago
parent
commit
d26415d54e
2 changed files with 7 additions and 20 deletions
  1. 1 1
      package.json
  2. 6 19
      packages/debugger/test/service.spec.ts

+ 1 - 1
package.json

@@ -79,7 +79,7 @@
     "prepare:python-release": "node buildutils/lib/prepare-python-release.js",
     "prepublish:check": "node buildutils/lib/prepublish-check.js",
     "prettier": "prettier --write \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
-    "prettier:check": "prettier --list-different \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
+    "prettier:check": "prettier --check \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
     "publish:js": "node buildutils/lib/publish.js",
     "remove:dependency": "node buildutils/lib/remove-dependency.js",
     "remove:package": "node buildutils/lib/remove-package.js",

+ 6 - 19
packages/debugger/test/service.spec.ts

@@ -55,24 +55,8 @@ describe('Debugging support', () => {
   let specsManager: TestKernelSpecManager;
   let service: Debugger.Service;
   let config: IDebugger.IConfig;
-  let xpython: Session.ISessionConnection;
-  let pyNoDebug: Session.ISessionConnection;
 
   beforeAll(async () => {
-    xpython = await createSession({
-      name: '',
-      type: 'test',
-      path: UUID.uuid4()
-    });
-    await xpython.changeKernel({ name: 'xpython' });
-
-    pyNoDebug = await createSession({
-      name: '',
-      type: 'test',
-      path: UUID.uuid4()
-    });
-    await pyNoDebug.changeKernel({ name: 'python3' });
-
     specsManager = new TestKernelSpecManager({ standby: 'never' });
     specsManager.intercept = specs;
     await specsManager.refreshSpecs();
@@ -81,20 +65,23 @@ describe('Debugging support', () => {
   });
 
   afterAll(async () => {
-    await Promise.all([xpython.shutdown(), pyNoDebug.shutdown()]);
     service.dispose();
     specsManager.dispose();
   });
 
   describe('#isAvailable', () => {
     it('should return true for kernels that have support for debugging', async () => {
-      const enabled = await service.isAvailable(xpython);
+      const enabled = await service.isAvailable({
+        kernel: { name: 'xpython' }
+      } as any);
       expect(enabled).toBe(true);
     });
 
     it('should return false for kernels that do not have support for debugging', async () => {
       // The kernel spec are mocked in KERNELSPECS
-      const enabled = await service.isAvailable(pyNoDebug);
+      const enabled = await service.isAvailable({
+        kernel: { name: 'python3' }
+      } as any);
       expect(enabled).toBe(false);
     });
   });