فهرست منبع

Backport PR #12551: Add cell-toolbar to CI and labeler (#12555)

Frédéric Collonval 3 سال پیش
والد
کامیت
d8d94b351d

+ 6 - 0
.github/labeler.yml

@@ -44,6 +44,12 @@ pkg:attachments:
   - packages/attachments/**/*
   - packages/attachments/*
 
+pkg:cell-toolbar:
+  - packages/cell-toolbar/**/*
+  - packages/cell-toolbar/*
+  - packages/cell-toolbar-extension/**/*
+  - packages/cell-toolbar-extension/*
+
 pkg:cells:
   - packages/cells/**/*
   - packages/cells/*

+ 35 - 1
.github/workflows/linuxjs-tests.yml

@@ -13,7 +13,41 @@ jobs:
     name: JS
     strategy:
       matrix:
-        group: [js-application, js-cells, js-codeeditor, js-codemirror, js-completer, js-console, js-coreutils, js-csvviewer, js-debugger, js-docmanager, js-docregistry, js-documentsearch, js-filebrowser, js-fileeditor, js-imageviewer, js-inspector, js-logconsole, js-mainmenu, js-nbformat, js-notebook, js-observables, js-outputarea, js-rendermime,  js-settingregistry, js-statedb, js-statusbar, js-terminal, js-toc, js-translation, js-ui-components, js-testutils]
+        group:
+          [
+            js-application,
+            js-cells,
+            js-cell-toolbar,
+            js-codeeditor,
+            js-codemirror,
+            js-completer,
+            js-console,
+            js-coreutils,
+            js-csvviewer,
+            js-debugger,
+            js-docmanager,
+            js-docregistry,
+            js-documentsearch,
+            js-filebrowser,
+            js-fileeditor,
+            js-imageviewer,
+            js-inspector,
+            js-logconsole,
+            js-mainmenu,
+            js-nbformat,
+            js-notebook,
+            js-observables,
+            js-outputarea,
+            js-rendermime,
+            js-settingregistry,
+            js-statedb,
+            js-statusbar,
+            js-terminal,
+            js-toc,
+            js-translation,
+            js-ui-components,
+            js-testutils,
+          ]
       fail-fast: false
     runs-on: ubuntu-20.04
     timeout-minutes: 20

+ 1 - 1
packages/cell-toolbar/src/index.ts

@@ -6,4 +6,4 @@
  * @packageDocumentation
  * @module cell-toolbar
  */
-export { CellBarExtension } from './celltoolbartracker';
+export * from './celltoolbartracker';

+ 3 - 38
packages/cell-toolbar/test/celltoolbartracker.spec.ts

@@ -6,52 +6,20 @@ import {
   createToolbarFactory,
   ToolbarWidgetRegistry
 } from '@jupyterlab/apputils';
-import { CellBarExtension } from '@jupyterlab/cell-toolbar';
+import { CellBarExtension, CellToolbarTracker } from '@jupyterlab/cell-toolbar';
 import { NotebookPanel } from '@jupyterlab/notebook';
 import { ISettingRegistry, SettingRegistry } from '@jupyterlab/settingregistry';
 import { IDataConnector } from '@jupyterlab/statedb';
 import { NBTestUtils } from '@jupyterlab/testutils';
 import { ITranslator } from '@jupyterlab/translation';
-
 import { CommandRegistry } from '@lumino/commands';
-import { Signal } from '@lumino/signaling';
-
-import { CellToolbarTracker } from '../src/celltoolbartracker';
-
-class TestSettings implements ISettingRegistry.ISettings {
-  changed = new Signal<this, void>(this);
-  composite = {};
-  id = 'test-settings';
-  isDisposed = false;
-  plugin = {
-    id: 'test-plugin',
-    data: {
-      composite: {},
-      user: {}
-    }, // ISettingBundle
-    raw: '',
-    schema: { type: 'object' } as ISettingRegistry.ISchema,
-    version: '0.0.1'
-  };
-  raw = '';
-  schema = { type: 'object' } as ISettingRegistry.ISchema;
-  user = {};
-  version = '0.0.2';
-  annotatedDefaults = jest.fn();
-  default = jest.fn();
-  get = jest.fn();
-  remove = jest.fn();
-  save = jest.fn();
-  set = jest.fn();
-  validate = jest.fn();
-  dispose = jest.fn();
-}
+import { Widget } from '@lumino/widgets';
 
 function testToolbarFactory() {
   const pluginId = '@jupyterlab/cell-toolbar';
 
   const toolbarRegistry = new ToolbarWidgetRegistry({
-    defaultFactory: jest.fn()
+    defaultFactory: jest.fn().mockImplementation(() => new Widget())
   });
 
   const bar: ISettingRegistry.IPlugin = {
@@ -159,7 +127,6 @@ describe('@jupyterlab/cell-toolbar', () => {
 
   describe('CellToolbarTracker', () => {
     let commands: CommandRegistry;
-    let settings: ISettingRegistry.ISettings;
     let panel: NotebookPanel;
     let extension: CellBarExtension;
 
@@ -172,8 +139,6 @@ describe('@jupyterlab/cell-toolbar', () => {
         execute: args => null
       });
 
-      settings = new TestSettings();
-
       extension = new CellBarExtension(commands, testToolbarFactory());
     });