Prechádzať zdrojové kódy

services: Handle undefined error event

When trying to connect to an address where no server is running it seams that the error event can be undefined. This will result in an internal error since `event.message` cannot be accessed.

Noticed while upgrading to the latest version of `@jupyterlab/services`: https://github.com/nteract/hydrogen/pull/908
Lukas Geiger 7 rokov pred
rodič
commit
e99ad2a9bf
1 zmenil súbory, kde vykonal 2 pridanie a 2 odobranie
  1. 2 2
      packages/services/src/serverconnection.ts

+ 2 - 2
packages/services/src/serverconnection.ts

@@ -328,8 +328,8 @@ namespace Private {
       delegate.reject({ xhr, event, request, settings, message: 'Aborted' });
     };
 
-    xhr.onerror = (event: ErrorEvent) => {
-      delegate.reject({ xhr, event, request, settings, message: event.message });
+    xhr.onerror = (event?: ErrorEvent) => {
+      delegate.reject({ xhr, event, request, settings, message: event ? event.message : 'Errored' });
     };
 
     xhr.ontimeout = (event: ProgressEvent) => {