Browse Source

fix ordering

Steven Silvester 6 years ago
parent
commit
fbd845d5ef
2 changed files with 4 additions and 3 deletions
  1. 3 1
      examples/example_check.py
  2. 1 2
      jupyterlab/browser_check.py

+ 3 - 1
examples/example_check.py

@@ -51,10 +51,12 @@ class ExampleCheckApp(mod.ExampleApp):
     ip = '127.0.0.1'
 
     def start(self):
+        self.log.addHandler(LogErrorHandler())
+
         pool = ThreadPoolExecutor()
         future = pool.submit(run_browser, self.display_url)
         IOLoop.current().add_future(future, self._browser_finished)
-        self.log.addHandler(LogErrorHandler())
+
         super().start()
 
     def _browser_finished(self, future):

+ 1 - 2
jupyterlab/browser_check.py

@@ -53,11 +53,10 @@ class BrowserApp(LabApp):
         web_app.settings.setdefault('page_config_data', dict())
         web_app.settings['page_config_data']['browserTest'] = True
         web_app.settings['page_config_data']['buildAvailable'] = False
-
+        self.log.addHandler(LogErrorHandler())
         pool = ThreadPoolExecutor()
         future = pool.submit(run_browser, self.display_url)
         IOLoop.current().add_future(future, self._browser_finished)
-        self.log.addHandler(LogErrorHandler())
         super(BrowserApp, self).start()
 
     def _browser_finished(self, future):