Przeglądaj źródła

Strip out old PDF rendering.

ian-r-rose 7 lat temu
rodzic
commit
52c968c1da

+ 0 - 12
packages/rendermime/src/factories.ts

@@ -54,17 +54,6 @@ const markdownRendererFactory: IRenderMime.IRendererFactory = {
 };
 
 
-/**
- * A mime renderer factory for pdf.
- */
-export
-const pdfRendererFactory: IRenderMime.IRendererFactory = {
-  safe: false,
-  mimeTypes: ['application/pdf'],
-  createRenderer: options => new widgets.RenderedPDF(options)
-};
-
-
 /**
  * A mime renderer factory for svg.
  */
@@ -108,7 +97,6 @@ const defaultRendererFactories: ReadonlyArray<IRenderMime.IRendererFactory> = [
   latexRendererFactory,
   svgRendererFactory,
   imageRendererFactory,
-  pdfRendererFactory,
   javaScriptRendererFactory,
   textRendererFactory
 ];

+ 0 - 62
packages/rendermime/src/renderers.ts

@@ -394,68 +394,6 @@ namespace renderMarkdown {
   }
 }
 
-
-/**
- * Render a PDF into a host node.
- *
- * @params options - The options for rendering.
- *
- * @returns A promise which resolves when rendering is complete.
- */
-export
-function renderPDF(options: renderPDF.IRenderOptions): Promise<void> {
-  // Unpack the options.
-  let { host, source, trusted } = options;
-
-  // Clear the content if there is no source.
-  if (!source) {
-    host.textContent = '';
-    return Promise.resolve(undefined);
-  }
-
-  // Display a message if the source is not trusted.
-  if (!trusted) {
-    host.textContent = 'Cannot display an untrusted PDF. Maybe you need to run the cell?';
-    return Promise.resolve(undefined);
-  }
-
-  // Update the host with the display content.
-  let href = `data:application/pdf;base64,${source}`;
-  host.innerHTML = `<a target="_blank" href="${href}">View PDF</a>`;
-
-  // Return the final rendered promise.
-  return Promise.resolve(undefined);
-}
-
-
-/**
- * The namespace for the `renderPDF` function statics.
- */
-export
-namespace renderPDF {
-  /**
-   * The options for the `renderPDF` function.
-   */
-  export
-  interface IRenderOptions {
-    /**
-     * The host node for the rendered PDF.
-     */
-    host: HTMLElement;
-
-    /**
-     * The base64 encoded source for the PDF.
-     */
-    source: string;
-
-    /**
-     * Whether the source is trusted.
-     */
-    trusted: boolean;
-  }
-}
-
-
 /**
  * Render SVG into a host node.
  *

+ 0 - 28
packages/rendermime/src/widgets.ts

@@ -271,34 +271,6 @@ class RenderedMarkdown extends RenderedHTMLCommon {
 }
 
 
-/**
- * A widget for displaying rendered PDF content.
- */
-export
-class RenderedPDF extends RenderedCommon {
-  /**
-   * Construct a new rendered PDF widget.
-   *
-   * @param options - The options for initializing the widget.
-   */
-  constructor(options: IRenderMime.IRendererOptions) {
-    super(options);
-    this.addClass('jp-RenderedPDF');
-  }
-
-  /**
-   * Render a mime model.
-   */
-  render(model: IRenderMime.IMimeModel): Promise<void> {
-    return renderers.renderPDF({
-      host: this.node,
-      source: String(model.data[this.mimeType]),
-      trusted: model.trusted
-    });
-  }
-}
-
-
 /**
  * A widget for displaying SVG content.
  */

+ 1 - 39
test/src/rendermime/factories.spec.ts

@@ -16,7 +16,7 @@ import {
 } from '@jupyterlab/apputils';
 
 import {
-  latexRendererFactory, pdfRendererFactory, svgRendererFactory,
+  latexRendererFactory, svgRendererFactory,
   markdownRendererFactory, textRendererFactory, htmlRendererFactory,
   imageRendererFactory
 } from '@jupyterlab/rendermime';
@@ -135,44 +135,6 @@ describe('rendermime/factories', () => {
 
   });
 
-  describe('pdfRendererFactory', () => {
-
-    describe('#mimeTypes', () => {
-
-      it('should have the application/pdf mimeType', () => {
-        expect(pdfRendererFactory.mimeTypes).to.eql(['application/pdf']);
-      });
-
-    });
-
-    describe('#safe', () => {
-
-      it('should be unsafe', () => {
-        expect(pdfRendererFactory.safe).to.be(false);
-      });
-
-    });
-
-    describe('#createRenderer()', () => {
-
-      it('should render the correct HTML', () => {
-        let source = 'test';
-        let f = pdfRendererFactory;
-        let mimeType = 'application/pdf';
-        let model = createModel(mimeType, source, true);
-        let w = f.createRenderer({ mimeType, ...defaultOptions });
-        return w.renderModel(model).then(() => {
-          let node = w.node.firstChild as HTMLAnchorElement;
-          expect(node.localName).to.be('a');
-          expect(node.target).to.be('_blank');
-          expect(node.href).to.be('data:application/pdf;base64,test');
-        });
-      });
-
-    });
-
-  });
-
   describe('svgRendererFactory', () => {
 
     describe('#mimeTypes', () => {